drashna/ryujinx
1
0
Fork 0
Code Activity Actions

hle: Tidy-up ServiceNotImplementedException (#2535)

Browse source 
* hle: Simplify ServiceNotImplementedException

This removes the need to pass in whether the command is a Tipc command or a Hipc command to the exception constructor.

* hle: Use the IPC Message type to determine command type

This allows differentiating between Tipc and Hipc commands when invoking a handler that supports handling both Tipc and Hipc commands.
This commit is contained in:
jduncanator 2021-08-12 05:16:42 +10:00 • committed by GitHub
parent d9d18439f6
commit b5b7e23fc4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 33 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Ryujinx.HLE/HOS/Services/Time/ITimeServiceManager.cs
View file

@ -149,7 +149,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
public ResultCode Unknown50(ServiceCtx context)
{
// TODO: figure out the usage of this event
throw new ServiceNotImplementedException(this, context, false);
throw new ServiceNotImplementedException(this, context);
}
[CommandHipc(51)]
@ -157,7 +157,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
public ResultCode Unknown51(ServiceCtx context)
{
// TODO: figure out the usage of this event
throw new ServiceNotImplementedException(this, context, false);
throw new ServiceNotImplementedException(this, context);
}
[CommandHipc(52)]
@ -165,7 +165,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
public ResultCode Unknown52(ServiceCtx context)
{
// TODO: figure out the usage of this event
throw new ServiceNotImplementedException(this, context, false);
throw new ServiceNotImplementedException(this, context);
}
[CommandHipc(60)]
@ -201,7 +201,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
public ResultCode GetAlarmRegistrationEvent(ServiceCtx context)
{
// TODO
throw new ServiceNotImplementedException(this, context, false);
throw new ServiceNotImplementedException(this, context);
}
[CommandHipc(201)]
@ -209,7 +209,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
public ResultCode UpdateSteadyAlarms(ServiceCtx context)
{
// TODO
throw new ServiceNotImplementedException(this, context, false);
throw new ServiceNotImplementedException(this, context);
}
[CommandHipc(202)]
@ -217,7 +217,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
public ResultCode TryGetNextSteadyClockAlarmSnapshot(ServiceCtx context)
{
// TODO
throw new ServiceNotImplementedException(this, context, false);
throw new ServiceNotImplementedException(this, context);
}
}
}