Misc cleanup (#708)

* Fix typos

* Remove unneeded using statements

* Enforce var style more

* Remove redundant qualifiers

* Fix some indentation

* Disable naming warnings on files with external enum names

* Fix build

* Mass find & replace for comments with no spacing

* Standardize todo capitalization and for/if spacing
This commit is contained in:
Alex Barney 2019-07-01 21:39:22 -05:00 committed by Ac_K
parent 10c74182ba
commit b2b736abc2
205 changed files with 1020 additions and 1041 deletions

View file

@ -1,4 +1,5 @@
namespace Ryujinx.HLE.HOS.Services.Android
// ReSharper disable InconsistentNaming
namespace Ryujinx.HLE.HOS.Services.Android
{
class ColorShift
{

View file

@ -150,7 +150,7 @@ namespace Ryujinx.HLE.HOS.Services.Android
if (Header.IntsCount != 0x51)
{
throw new System.NotImplementedException($"Unexpected Graphic Buffer ints count (expected 0x51, found 0x{Header.IntsCount:x}");
throw new NotImplementedException($"Unexpected Graphic Buffer ints count (expected 0x51, found 0x{Header.IntsCount:x}");
}
Buffer = reader.ReadStruct<NvGraphicBuffer>();

View file

@ -81,7 +81,7 @@ namespace Ryujinx.HLE.HOS.Services.Vi
MemoryHelper.FillWithZeros(context.Memory, recBuffPtr, 0x60);
//Add only the default display to buffer
// Add only the default display to buffer
context.Memory.WriteBytes(recBuffPtr, Encoding.ASCII.GetBytes("Default"));
context.Memory.WriteInt64(recBuffPtr + 0x40, 0x1L);
context.Memory.WriteInt64(recBuffPtr + 0x48, 0x1L);
@ -186,14 +186,14 @@ namespace Ryujinx.HLE.HOS.Services.Vi
if (!convertedScalingMode.HasValue)
{
//Scaling mode out of the range of valid values.
// Scaling mode out of the range of valid values.
return MakeError(ErrorModule.Vi, 1);
}
if (scalingMode != SrcScalingMode.ScaleToWindow &&
scalingMode != SrcScalingMode.PreserveAspectRatio)
{
//Invalid scaling mode specified.
// Invalid scaling mode specified.
return MakeError(ErrorModule.Vi, 6);
}
@ -239,7 +239,7 @@ namespace Ryujinx.HLE.HOS.Services.Vi
{
BinaryWriter writer = new BinaryWriter(ms);
//flat_binder_object (size is 0x28)
// flat_binder_object (size is 0x28)
writer.Write(2); //Type (BINDER_TYPE_WEAK_BINDER)
writer.Write(0); //Flags
writer.Write((int)(id >> 0));

View file

@ -37,7 +37,7 @@ namespace Ryujinx.HLE.HOS.Services.Vi
public static long GetDisplayMode(ServiceCtx context)
{
//TODO: De-hardcode resolution.
// TODO: De-hardcode resolution.
context.ResponseData.Write(1280);
context.ResponseData.Write(720);
context.ResponseData.Write(60.0f);

View file

@ -1,7 +1,6 @@
using Ryujinx.Common.Logging;
using Ryujinx.Graphics.Gal;
using Ryujinx.Graphics.Memory;
using Ryujinx.HLE.HOS.Kernel;
using Ryujinx.HLE.HOS.Kernel.Threading;
using Ryujinx.HLE.HOS.Services.Nv.NvGpuAS;
using Ryujinx.HLE.HOS.Services.Nv.NvMap;
@ -213,7 +212,7 @@ namespace Ryujinx.HLE.HOS.Services.Android
private long GbpDequeueBuffer(ServiceCtx context, BinaryReader parcelReader)
{
//TODO: Errors.
// TODO: Errors.
int format = parcelReader.ReadInt32();
int width = parcelReader.ReadInt32();
int height = parcelReader.ReadInt32();
@ -229,7 +228,7 @@ namespace Ryujinx.HLE.HOS.Services.Android
{
context.Device.Statistics.RecordGameFrameTime();
//TODO: Errors.
// TODO: Errors.
int slot = parcelReader.ReadInt32();
long Position = parcelReader.BaseStream.Position;
@ -260,7 +259,7 @@ namespace Ryujinx.HLE.HOS.Services.Android
private long GbpCancelBuffer(ServiceCtx context, BinaryReader parcelReader)
{
//TODO: Errors.
// TODO: Errors.
int slot = parcelReader.ReadInt32();
MultiFence fence = ReadFlattenedObject<MultiFence>(parcelReader);
@ -401,7 +400,7 @@ namespace Ryujinx.HLE.HOS.Services.Android
int BlockHeight = 1 << _bufferQueue[slot].Data.Buffer.Surfaces[0].BlockHeightLog2;
//Note: Rotation is being ignored.
// Note: Rotation is being ignored.
int top = crop.Top;
int left = crop.Left;