drashna/ryujinx
1
0
Fork 0
Code Activity Actions

Salieri: Detect and avoid caching shaders using bindless textures (#2097)

Browse source 
* Salieri: Add blacklist system and blacklist shaders using bindless

Currently the shader cache doesn't have the right format to support
bindless textures correctly and may cache shaders that it cannot rebuild
after host invalidation.

This PR address the issue by blacklisting shaders using bindless
textures.

THis also support detection of already cached broken shader and handle removal
of those.

* Move to a feature flags design to avoid intrusive changes in the translator

This remove the auto correct behaviour

* Reduce diff on TranslationFlags

* Reduce comma on last entry of TranslationFlags

* Fix inverted logic and remove leftovers

* remove debug edits oops
This commit is contained in:
Mary 2021-03-19 20:07:37 +01:00 • committed by GitHub
parent 9b7335a63b
commit aef25980a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 39 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Ryujinx.Graphics.Gpu/Shader/ShaderCache.cs
View file

@ -195,7 +195,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
if (tfd != null)
{
flags = TranslationFlags.Feedback;
flags |= TranslationFlags.Feedback;
}
TranslationCounts counts = new TranslationCounts();
@ -426,6 +426,8 @@ namespace Ryujinx.Graphics.Gpu.Shader
// The shader isn't currently cached, translate it and compile it.
ShaderCodeHolder shader = TranslateShader(shaderContexts[0]);
bool isDiskShaderCacheIncompatible = shaderContexts[0].UsedFeatures.HasFlag(FeatureFlags.Bindless);
shader.HostShader = _context.Renderer.CompileShader(ShaderStage.Compute, shader.Program.Code);
IProgram hostProgram = _context.Renderer.CreateProgram(new IShader[] { shader.HostShader }, null);
@ -434,7 +436,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
cpShader = new ShaderBundle(hostProgram, shader);
if (isShaderCacheEnabled)
if (isShaderCacheEnabled && !isDiskShaderCacheIncompatible)
{
_cpProgramsDiskCache.Add(programCodeHash, cpShader);
@ -540,6 +542,17 @@ namespace Ryujinx.Graphics.Gpu.Shader
shaders[3] = TranslateShader(shaderContexts[4]);
shaders[4] = TranslateShader(shaderContexts[5]);
bool isDiskShaderCacheIncompatible = false;
for (int i = 0; i < shaderContexts.Length; i++)
{
if (shaderContexts[i] != null && shaderContexts[i].UsedFeatures.HasFlag(FeatureFlags.Bindless))
{
isDiskShaderCacheIncompatible = true;
break;
}
}
List<IShader> hostShaders = new List<IShader>();
for (int stage = 0; stage < Constants.ShaderStages; stage++)
@ -564,7 +577,7 @@ namespace Ryujinx.Graphics.Gpu.Shader
gpShaders = new ShaderBundle(hostProgram, shaders);
if (isShaderCacheEnabled)
if (isShaderCacheEnabled && !isDiskShaderCacheIncompatible)
{
_gpProgramsDiskCache.Add(programCodeHash, gpShaders);