Adjust naming conventions and general refactoring in HLE Project (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters
This commit is contained in:
Alex Barney 2018-12-04 14:23:37 -06:00 committed by gdkchan
parent c86aacde76
commit 85dbb9559a
299 changed files with 12268 additions and 12276 deletions

View file

@ -11,43 +11,43 @@ namespace Ryujinx.HLE
{
public class Switch : IDisposable
{
internal IAalOutput AudioOut { get; private set; }
internal IAalOutput AudioOut { get; }
internal DeviceMemory Memory { get; private set; }
internal DeviceMemory Memory { get; }
internal NvGpu Gpu { get; private set; }
internal NvGpu Gpu { get; }
internal VirtualFileSystem FileSystem { get; private set; }
internal VirtualFileSystem FileSystem { get; }
public Horizon System { get; private set; }
public Horizon System { get; }
public PerformanceStatistics Statistics { get; private set; }
public PerformanceStatistics Statistics { get; }
public Hid Hid { get; private set; }
public Hid Hid { get; }
public bool EnableDeviceVsync { get; set; } = true;
public AutoResetEvent VsyncEvent { get; private set; }
public AutoResetEvent VsyncEvent { get; }
public event EventHandler Finish;
public Switch(IGalRenderer Renderer, IAalOutput AudioOut)
public Switch(IGalRenderer renderer, IAalOutput audioOut)
{
if (Renderer == null)
if (renderer == null)
{
throw new ArgumentNullException(nameof(Renderer));
throw new ArgumentNullException(nameof(renderer));
}
if (AudioOut == null)
if (audioOut == null)
{
throw new ArgumentNullException(nameof(AudioOut));
throw new ArgumentNullException(nameof(audioOut));
}
this.AudioOut = AudioOut;
AudioOut = audioOut;
Memory = new DeviceMemory();
Gpu = new NvGpu(Renderer);
Gpu = new NvGpu(renderer);
FileSystem = new VirtualFileSystem();
@ -60,29 +60,29 @@ namespace Ryujinx.HLE
VsyncEvent = new AutoResetEvent(true);
}
public void LoadCart(string ExeFsDir, string RomFsFile = null)
public void LoadCart(string exeFsDir, string romFsFile = null)
{
System.LoadCart(ExeFsDir, RomFsFile);
System.LoadCart(exeFsDir, romFsFile);
}
public void LoadXci(string XciFile)
public void LoadXci(string xciFile)
{
System.LoadXci(XciFile);
System.LoadXci(xciFile);
}
public void LoadNca(string NcaFile)
public void LoadNca(string ncaFile)
{
System.LoadNca(NcaFile);
System.LoadNca(ncaFile);
}
public void LoadNsp(string NspFile)
public void LoadNsp(string nspFile)
{
System.LoadNsp(NspFile);
System.LoadNsp(nspFile);
}
public void LoadProgram(string FileName)
public void LoadProgram(string fileName)
{
System.LoadProgram(FileName);
System.LoadProgram(fileName);
}
public bool WaitFifo()
@ -107,9 +107,9 @@ namespace Ryujinx.HLE
Dispose(true);
}
protected virtual void Dispose(bool Disposing)
protected virtual void Dispose(bool disposing)
{
if (Disposing)
if (disposing)
{
System.Dispose();