drashna/ryujinx
1
0
Fork 0
Code Activity Actions

Adjust naming conventions and general refactoring in HLE Project (#490)

Browse source 
* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters
This commit is contained in:
Alex Barney 2018-12-04 14:23:37 -06:00 • committed by gdkchan
parent c86aacde76
commit 85dbb9559a
299 changed files with 12268 additions and 12276 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Ryujinx.HLE/HOS/Services/Ssl/ISslService.cs
View file

@ -6,13 +6,13 @@ namespace Ryujinx.HLE.HOS.Services.Ssl
{
class ISslService : IpcService
{
private Dictionary<int, ServiceProcessRequest> m_Commands;
private Dictionary<int, ServiceProcessRequest> _commands;
public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
public ISslService()
{
m_Commands = new Dictionary<int, ServiceProcessRequest>()
_commands = new Dictionary<int, ServiceProcessRequest>
{
{ 0, CreateContext },
{ 5, SetInterfaceVersion }
@ -20,24 +20,24 @@ namespace Ryujinx.HLE.HOS.Services.Ssl
}
// CreateContext(nn::ssl::sf::SslVersion, u64, pid) -> object<nn::ssl::sf::ISslContext>
public long CreateContext(ServiceCtx Context)
public long CreateContext(ServiceCtx context)
{
int SslVersion = Context.RequestData.ReadInt32();
long Unknown = Context.RequestData.ReadInt64();
int sslVersion = context.RequestData.ReadInt32();
long unknown = context.RequestData.ReadInt64();
Logger.PrintStub(LogClass.ServiceSsl, $"Stubbed. SslVersion: {SslVersion} - Unknown: {Unknown}");
Logger.PrintStub(LogClass.ServiceSsl, $"Stubbed. SslVersion: {sslVersion} - Unknown: {unknown}");
MakeObject(Context, new ISslContext());
MakeObject(context, new ISslContext());
return 0;
}
// SetInterfaceVersion(u32)
public long SetInterfaceVersion(ServiceCtx Context)
public long SetInterfaceVersion(ServiceCtx context)
{
int Version = Context.RequestData.ReadInt32();
int version = context.RequestData.ReadInt32();
Logger.PrintStub(LogClass.ServiceSsl, $"Stubbed. Version: {Version}");
Logger.PrintStub(LogClass.ServiceSsl, $"Stubbed. Version: {version}");
return 0;
}