[Core] Replace Tapping Force Hold feature with Quick Tap Term (#17007)
* Replace Tapping Force Hold feature with Quick Tap Term * Replace keyboard level TAPPING_FORCE_HOLD with QUICK_TAP_TERM 0 * Deprecate force hold in info_config.json * Before and after quick tap term unit tests * Quick tap unit tests iteration * Keymap config.h correction * Remove TAPPING_FORCE_HOLD_PER_KEY macros that were missed * Add two more test cases for quick tap * Replace TAPPING_FORCE_HOLD with QUICK_TAP_TERM in configs #2 * Replace TAPPING_FORCE_HOLD_PER_KEY with QUICK_TAP_TERM_PER_KEY in configs #2 * Add function declaration for get_quick_tap_term Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
This commit is contained in:
parent
8698d109d7
commit
cbabc8dbe6
226 changed files with 462 additions and 380 deletions
|
@ -35,5 +35,5 @@
|
|||
#define PERMISSIVE_HOLD
|
||||
#define IGNORE_MOD_TAP_INTERRUPT
|
||||
#define IGNORE_MOD_TAP_INTERRUPT_PER_KEY
|
||||
#define TAPPING_FORCE_HOLD
|
||||
#define TAPPING_FORCE_HOLD_PER_KEY
|
||||
#define QUICK_TAP_TERM 0
|
||||
#define QUICK_TAP_TERM_PER_KEY
|
||||
|
|
|
@ -229,7 +229,7 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
|
|||
return true;
|
||||
}
|
||||
|
||||
bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
|
||||
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
|
||||
switch (keycode) {
|
||||
case SHFTESC:
|
||||
case NUMSPAC:
|
||||
|
@ -249,9 +249,9 @@ bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
|
|||
case CTL__J:
|
||||
case CTL__T:
|
||||
case CTL__N:
|
||||
return true;
|
||||
return 0;
|
||||
default:
|
||||
return false;
|
||||
return QUICK_TAP_TERM;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -58,7 +58,7 @@
|
|||
#define TAPPING_TERM_PER_KEY
|
||||
//#define PERMISSIVE_HOLD
|
||||
#define IGNORE_MOD_TAP_INTERRUPT
|
||||
#define TAPPING_FORCE_HOLD_PER_KEY
|
||||
#define QUICK_TAP_TERM_PER_KEY
|
||||
|
||||
// settings for LEADER key
|
||||
#define LEADER_PER_KEY_TIMING
|
||||
|
|
|
@ -1039,30 +1039,30 @@ bool music_mask_user(uint16_t keycode) {
|
|||
}
|
||||
}
|
||||
|
||||
bool get_tapping_force_hold(uint16_t keycode, keyrecord_t *record) {
|
||||
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t *record) {
|
||||
switch (keycode) {
|
||||
case LSFT_T(KC_S):
|
||||
return true;
|
||||
return 0;
|
||||
case RSFT_T(KC_E):
|
||||
return true;
|
||||
return 0;
|
||||
case LSFT_T(KC_D):
|
||||
return true;
|
||||
return 0;
|
||||
case RSFT_T(KC_K):
|
||||
return true;
|
||||
return 0;
|
||||
case LSFT_T(KC_F):
|
||||
return true;
|
||||
return 0;
|
||||
case RSFT_T(KC_U):
|
||||
return true;
|
||||
return 0;
|
||||
case LT(_RAISE, KC_ENT):
|
||||
return true;
|
||||
return 0;
|
||||
case LT(_RAISE_DE, KC_ENT):
|
||||
return true;
|
||||
return 0;
|
||||
case LT(_LOWER, KC_BSPC):
|
||||
return true;
|
||||
return 0;
|
||||
case LT(_LOWER_DE, KC_BSPC):
|
||||
return true;
|
||||
return 0;
|
||||
default:
|
||||
return false;
|
||||
return QUICK_TAP_TERM;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -53,4 +53,4 @@
|
|||
#define IGNORE_MOD_TAP_INTERRUPT
|
||||
|
||||
// Enable rapid switch from tap to hold, disables double tap hold auto-repeat.
|
||||
#define TAPPING_FORCE_HOLD
|
||||
#define QUICK_TAP_TERM 0
|
||||
|
|
|
@ -117,7 +117,7 @@
|
|||
* MACRO per-key options
|
||||
*/
|
||||
#define RETRO_TAPPING_PER_KEY // Control Retro-Tap individually by key
|
||||
#define TAPPING_FORCE_HOLD_PER_KEY // Control Force-Hold individually by key
|
||||
#define QUICK_TAP_TERM_PER_KEY // Control Quick-Tap individually by key
|
||||
#define IGNORE_MOD_TAP_INTERRUPT_PER_KEY // Control Mod-Tap-Interrupt individually by key
|
||||
#define PERMISSIVE_HOLD_PER_KEY // Control Permissive-Hold individually by key
|
||||
|
||||
|
|
|
@ -1376,11 +1376,11 @@ bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t* record) {
|
|||
return false;
|
||||
}
|
||||
}
|
||||
// Handles per-key configuration of Tapping Force-Hold
|
||||
bool get_tapping_force_hold(uint16_t keycode, keyrecord_t* record) {
|
||||
// Handles per-key configuration of Quick-Tap
|
||||
uint16_t get_quick_tap_term(uint16_t keycode, keyrecord_t* record) {
|
||||
switch (keycode) {
|
||||
default:
|
||||
return false;
|
||||
return QUICK_TAP_TERM;
|
||||
}
|
||||
}
|
||||
// Handles per-key configuration of Permissive-Hold
|
||||
|
|
|
@ -12,7 +12,7 @@
|
|||
Set any config.h overrides for your specific keymap here.
|
||||
See config.h options at https://docs.qmk.fm/#/config_options?id=the-configh-file
|
||||
*/
|
||||
#define TAPPING_FORCE_HOLD
|
||||
#define QUICK_TAP_TERM 0
|
||||
#define IGNORE_MOD_TAP_INTERRUPT
|
||||
|
||||
#define EECONFIG_RGB_MATRIX (uint32_t *)16
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue