drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

Bigger combo index (#9318)

Browse source 
* Add change log

* Change combo index from uint8_t to uint16_t
This commit is contained in:
Pete Sevander 2020-07-16 15:39:01 +03:00 • committed by James Young
parent 93e7a8f74c
commit b0335b2731
16 changed files with 28 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

11
docs/ChangeLog/20200829/PR9318.md Normal file
View file

@ -0,0 +1,11 @@
### Bigger integer type when looping over combos.
[#9318](https://github.com/qmk/qmk_firmware/pull/9318)
Changes `uint8_t` to `uint16_t` so it is possible have more than 256 combos.
Any fork that uses `process_combo_event` needs to update the function's first argument to `uint16_t`.
| Old function | New Function |
|---------------------------------------------------------------|----------------------------------------------------------------|
| `void process_combo_event(uint8_t combo_index, bool pressed)` | `void process_combo_event(uint16_t combo_index, bool pressed)` |