drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

MILC: Use dashes instead of underscores for subcommands

Browse source 
The subcommand functions' name follows the Python convention of using
snake case, but looks odd on the command line.
Fix it by converting underscores to dashes, eg.: list_keyboards ->
list-keyboards.
This commit is contained in:
Erovia 2019-10-13 20:23:11 +02:00 • committed by skullydazed
parent 4da9d2ef6f
commit a5a31a5fc0
3 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/python/milc.py
View file

@ -429,11 +429,12 @@ class MILC(object):
self.arg_only.append(arg_name)
del kwargs['arg_only']
name = handler.__name__.replace("_", "-")
if handler is self._entrypoint:
self.add_argument(*args, **kwargs)
elif handler.__name__ in self.subcommands:
self.subcommands[handler.__name__].add_argument(*args, **kwargs)
elif name in self.subcommands:
self.subcommands[name].add_argument(*args, **kwargs)
else:
raise RuntimeError('Decorated function is not entrypoint or subcommand!')
@ -599,7 +600,7 @@ class MILC(object):
self.add_subparsers()
if not name:
name = handler.__name__
name = handler.__name__.replace("_", "-")
self.acquire_lock()
kwargs['help'] = description