Fix pressing two keys with the same keycode but different modifiers (#2710)
* Fix extra keyboard report during test_fixture teardown * Add tests for pressing two keys with only different modifers * Fix #1708 When two keys that use the same keycode, but different modifiers were pressed at the same time, the second keypress wasn't registered. This is fixed by forcing a key release when we detect a new press for the same keycode. * Fix the NKRO version of is_key_pressed * Fix uninitalized loop variable Co-authored-by: Jack Humbert <jack.humb@gmail.com>
This commit is contained in:
parent
f89439ae09
commit
9e8767917d
6 changed files with 158 additions and 5 deletions
|
@ -32,14 +32,15 @@ TestFixture::TestFixture() {}
|
|||
|
||||
TestFixture::~TestFixture() {
|
||||
TestDriver driver;
|
||||
layer_clear();
|
||||
clear_all_keys();
|
||||
// Run for a while to make sure all keys are completely released
|
||||
EXPECT_CALL(driver, send_keyboard_mock(_)).Times(AnyNumber());
|
||||
layer_clear();
|
||||
clear_all_keys();
|
||||
idle_for(TAPPING_TERM + 10);
|
||||
testing::Mock::VerifyAndClearExpectations(&driver);
|
||||
// Verify that the matrix really is cleared
|
||||
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport())).Times(Between(0, 1));
|
||||
EXPECT_CALL(driver, send_keyboard_mock(KeyboardReport())).Times(0);
|
||||
idle_for(TAPPING_TERM + 10);
|
||||
}
|
||||
|
||||
void TestFixture::run_one_scan_loop() {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue