From 9c397f665b01e0d5e48151b08816b6e1fbf3c3b3 Mon Sep 17 00:00:00 2001
From: Drashna Jael're <drashna@live.com>
Date: Sat, 26 Oct 2024 20:37:59 -0700
Subject: [PATCH] [MERGE][Core] suspend: suppress wake up keypress
 (23389-241026)

---
 platforms/suspend.c                 | 34 +++++++++++++++++++++++++++--
 platforms/suspend.h                 |  4 ++++
 quantum/keyboard.c                  |  4 +++-
 tmk_core/protocol/chibios/chibios.c |  3 +++
 tmk_core/protocol/lufa/lufa.c       |  3 +++
 tmk_core/protocol/vusb/protocol.c   |  3 +++
 6 files changed, 48 insertions(+), 3 deletions(-)

diff --git a/platforms/suspend.c b/platforms/suspend.c
index fea23cbd02..74b45a3327 100644
--- a/platforms/suspend.c
+++ b/platforms/suspend.c
@@ -4,6 +4,8 @@
 #include "suspend.h"
 #include "matrix.h"
 
+static matrix_row_t wakeup_matrix[MATRIX_ROWS];
+
 // TODO: Move to more correct location
 __attribute__((weak)) void matrix_power_up(void) {}
 __attribute__((weak)) void matrix_power_down(void) {}
@@ -44,8 +46,36 @@ bool suspend_wakeup_condition(void) {
     matrix_power_up();
     matrix_scan();
     matrix_power_down();
+
+    bool wakeup = false;
     for (uint8_t r = 0; r < MATRIX_ROWS; r++) {
-        if (matrix_get_row(r)) return true;
+        wakeup_matrix[r] = matrix_get_row(r);
+        wakeup |= wakeup_matrix[r] != 0;
+    }
+
+    return wakeup;
+}
+
+void wakeup_matrix_update(void) {
+    matrix_power_up();
+    matrix_scan();
+    matrix_power_down();
+
+    for (uint8_t row = 0; row < MATRIX_ROWS; row++) {
+        matrix_row_t matrix_row = matrix_get_row(row);
+        matrix_row_t col_mask   = 1;
+        for (uint8_t col = 0; col < MATRIX_COLS; col++, col_mask <<= 1) {
+            wakeup_matrix_handle_key_event(row, col, matrix_row & col_mask);
+        }
+    }
+}
+
+bool keypress_is_wakeup_key(uint8_t row, uint8_t col) {
+    return (wakeup_matrix[row] & ((matrix_row_t)1 << col));
+}
+
+void wakeup_matrix_handle_key_event(uint8_t row, uint8_t col, bool pressed) {
+    if (!pressed) {
+        wakeup_matrix[row] &= ~((matrix_row_t)1 << col);
     }
-    return false;
 }
diff --git a/platforms/suspend.h b/platforms/suspend.h
index e4f7f39ddb..dbaab90805 100644
--- a/platforms/suspend.h
+++ b/platforms/suspend.h
@@ -14,6 +14,10 @@ void suspend_power_down_user(void);
 void suspend_power_down_kb(void);
 void suspend_power_down_quantum(void);
 
+bool keypress_is_wakeup_key(uint8_t row, uint8_t col);
+void wakeup_matrix_update(void);
+void wakeup_matrix_handle_key_event(uint8_t row, uint8_t col, bool pressed);
+
 #ifndef USB_SUSPEND_WAKEUP_DELAY
 #    define USB_SUSPEND_WAKEUP_DELAY 0
 #endif
diff --git a/quantum/keyboard.c b/quantum/keyboard.c
index 9552c6d4cd..4540931912 100644
--- a/quantum/keyboard.c
+++ b/quantum/keyboard.c
@@ -32,6 +32,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "sendchar.h"
 #include "eeconfig.h"
 #include "action_layer.h"
+#include "suspend.h"
 #ifdef BOOTMAGIC_ENABLE
 #    include "bootmagic.h"
 #endif
@@ -510,6 +511,7 @@ void switch_events(uint8_t row, uint8_t col, bool pressed) {
     void haptic_handle_key_event(uint8_t row, uint8_t col, bool pressed);
     haptic_handle_key_event(row, col, pressed);
 #endif // HAPTIC_ENABLE && SPLIT_HAPTIC_ENABLE
+    wakeup_matrix_handle_key_event(row, col, pressed);
 }
 
 /**
@@ -573,7 +575,7 @@ static bool matrix_task(void) {
             if (row_changes & col_mask) {
                 const bool key_pressed = current_row & col_mask;
 
-                if (process_keypress) {
+                if (process_keypress && !keypress_is_wakeup_key(row, col)) {
                     action_exec(MAKE_KEYEVENT(row, col, key_pressed));
                 }
 
diff --git a/tmk_core/protocol/chibios/chibios.c b/tmk_core/protocol/chibios/chibios.c
index f4f3aa43a7..cf29af950d 100644
--- a/tmk_core/protocol/chibios/chibios.c
+++ b/tmk_core/protocol/chibios/chibios.c
@@ -192,6 +192,9 @@ void protocol_pre_task(void) {
                 //
                 // Pause for a while to let things settle...
                 wait_ms(USB_SUSPEND_WAKEUP_DELAY);
+                // ...and then update the wakeup matrix again as the waking key
+                // might have been released during the delay
+                wakeup_matrix_update();
 #    endif
             }
         }
diff --git a/tmk_core/protocol/lufa/lufa.c b/tmk_core/protocol/lufa/lufa.c
index 4a9ea427d8..ee9d80c56d 100644
--- a/tmk_core/protocol/lufa/lufa.c
+++ b/tmk_core/protocol/lufa/lufa.c
@@ -835,6 +835,9 @@ void protocol_pre_task(void) {
                 //
                 // Pause for a while to let things settle...
                 wait_ms(USB_SUSPEND_WAKEUP_DELAY);
+                // ...and then update the wakeup matrix again as the waking key
+                // might have been released during the delay
+                wakeup_matrix_update();
 #    endif
             }
         }
diff --git a/tmk_core/protocol/vusb/protocol.c b/tmk_core/protocol/vusb/protocol.c
index d4a81c044a..d4aba86e0d 100644
--- a/tmk_core/protocol/vusb/protocol.c
+++ b/tmk_core/protocol/vusb/protocol.c
@@ -144,6 +144,9 @@ void protocol_pre_task(void) {
                 //
                 // Pause for a while to let things settle...
                 wait_ms(USB_SUSPEND_WAKEUP_DELAY);
+                // ...and then update the wakeup matrix again as the waking key
+                // might have been released during the delay
+                wakeup_matrix_update();
 #    endif
             }
         }