[Enhancement] Improvements for debounce test coverage + bug fixes for sym_defer_g and sym_eager_pr (#21667)
Co-authored-by: Nebuleon <2391500+Nebuleon@users.noreply.github.com>
This commit is contained in:
parent
dd94877ec6
commit
960d6e0d7d
15 changed files with 458 additions and 23 deletions
256
quantum/debounce/tests/none_tests.cpp
Normal file
256
quantum/debounce/tests/none_tests.cpp
Normal file
|
@ -0,0 +1,256 @@
|
|||
/* Copyright 2021 Simon Arlott
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 2 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#include "gtest/gtest.h"
|
||||
|
||||
#include "debounce_test_common.h"
|
||||
|
||||
TEST_F(DebounceTest, OneKeyShort1) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
/* 0ms delay (fast scan rate) */
|
||||
{5, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{10, {}, {}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyShort2) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
/* 1ms delay */
|
||||
{6, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{11, {}, {}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyShort3) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
/* 2ms delay */
|
||||
{7, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{12, {}, {}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyTooQuick1) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
/* Release key exactly on the debounce time */
|
||||
{5, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyTooQuick2) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
{6, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
/* Press key exactly on the debounce time */
|
||||
{11, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyBouncing1) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{1, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{2, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{3, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{4, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{5, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{6, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{11, {{0, 1, UP}}, {{0, 1, UP}}}, /* 5ms after DOWN at time 7 */
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyBouncing2) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{5, {}, {}},
|
||||
{6, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{7, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{8, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{9, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{10, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{15, {}, {}}, /* 5ms after UP at time 10 */
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyLong) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
|
||||
{25, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{30, {}, {}},
|
||||
|
||||
{50, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
{55, {}, {}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, TwoKeysShort) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{1, {{0, 2, DOWN}}, {{0, 2, DOWN}}},
|
||||
|
||||
{6, {}, {}},
|
||||
|
||||
{7, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{8, {{0, 2, UP}}, {{0, 2, UP}}},
|
||||
|
||||
{13, {}, {}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, TwoKeysSimultaneous1) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}, {0, 2, DOWN}}, {{0, 1, DOWN}, {0, 2, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
{6, {{0, 1, UP}, {0, 2, UP}}, {{0, 1, UP}, {0, 2, UP}}},
|
||||
|
||||
{11, {}, {}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, TwoKeysSimultaneous2) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
{1, {{0, 2, DOWN}}, {{0, 2, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
{6, {}, {}},
|
||||
{7, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
{8, {{0, 2, UP}}, {{0, 2, UP}}},
|
||||
|
||||
{13, {}, {}},
|
||||
});
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyDelayedScan1) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
/* Processing is very late */
|
||||
{300, {}, {}},
|
||||
/* Immediately release key */
|
||||
{300, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{305, {}, {}},
|
||||
});
|
||||
time_jumps_ = true;
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyDelayedScan2) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
/* Processing is very late */
|
||||
{300, {}, {}},
|
||||
/* Release key after 1ms */
|
||||
{301, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{306, {}, {}},
|
||||
});
|
||||
time_jumps_ = true;
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyDelayedScan3) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
/* Release key before debounce expires */
|
||||
{300, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
});
|
||||
time_jumps_ = true;
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, OneKeyDelayedScan4) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
/* Processing is a bit late */
|
||||
{50, {}, {}},
|
||||
/* Release key after 1ms */
|
||||
{51, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{56, {}, {}},
|
||||
});
|
||||
time_jumps_ = true;
|
||||
runEvents();
|
||||
}
|
||||
|
||||
TEST_F(DebounceTest, AsyncTickOneKeyShort1) {
|
||||
addEvents({
|
||||
/* Time, Inputs, Outputs */
|
||||
{0, {{0, 1, DOWN}}, {{0, 1, DOWN}}},
|
||||
|
||||
{5, {}, {}},
|
||||
/* 0ms delay (fast scan rate) */
|
||||
{5, {{0, 1, UP}}, {{0, 1, UP}}},
|
||||
|
||||
{10, {}, {}},
|
||||
});
|
||||
/*
|
||||
* Debounce implementations should never read the timer more than once per invocation
|
||||
*/
|
||||
async_time_jumps_ = DEBOUNCE;
|
||||
runEvents();
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue