drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

[Bug] Add key event check to is_tap_record and remove is_tap_key (#18063)

Browse source
This commit is contained in:
Stefan Kerkmann 2022-08-15 16:40:51 +02:00 • committed by GitHub
parent 5e6175a553
commit 8ce946b5c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/tap_hold_configurations/default_mod_tap/test_tap_hold.cpp
View file

@ -140,8 +140,6 @@ TEST_F(DefaultTapHold, tap_regular_key_while_layer_tap_key_is_held) {
}
TEST_F(DefaultTapHold, tap_mod_tap_hold_key_two_times) {
GTEST_SKIP() << "TODO:Holding a modtap key results in out of bounds access to the keymap, this is a bug in QMK.";
TestDriver driver;
InSequence s;
auto mod_tap_hold_key = KeymapKey(0, 1, 0, SFT_T(KC_P));
@ -175,8 +173,6 @@ TEST_F(DefaultTapHold, tap_mod_tap_hold_key_two_times) {
}
TEST_F(DefaultTapHold, tap_mod_tap_hold_key_twice_and_hold_on_second_time) {
GTEST_SKIP() << "TODO:Holding a modtap key results in out of bounds access to the keymap, this is a bug in QMK.";
TestDriver driver;
InSequence s;
auto mod_tap_hold_key = KeymapKey(0, 1, 0, SFT_T(KC_P));