drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

[MERGE][Core] Add dirty chunk checking for all RGB and LED drivers (24872)

Browse source
This commit is contained in:
Drashna Jael're 2025-01-26 04:52:39 -08:00
parent 0324612c37
commit 4a138dd93c
Signed by: drashna
GPG key ID: DBA1FD3A860D1B11
28 changed files with 690 additions and 286 deletions
Download patch file Download diff file Expand all files Collapse all files

41
drivers/led/issi/is31fl3733.c
View file

@ -62,6 +62,9 @@
# define IS31FL3733_SYNC_4 IS31FL3733_SYNC_NONE
#endif
#define IS31FL3733_PWM_REGISTERS_PER_CHUNK 16
#define IS31FL3733_CHUNK_COUNT (IS31FL3733_PWM_REGISTER_COUNT / IS31FL3733_PWM_REGISTERS_PER_CHUNK)
const uint8_t i2c_addresses[IS31FL3733_DRIVER_COUNT] = {
IS31FL3733_I2C_ADDRESS_1,
#ifdef IS31FL3733_I2C_ADDRESS_2
@ -96,16 +99,17 @@ const uint8_t driver_sync[IS31FL3733_DRIVER_COUNT] = {
// probably not worth the extra complexity.
typedef struct is31fl3733_driver_t {
uint8_t pwm_buffer[IS31FL3733_PWM_REGISTER_COUNT];
bool pwm_buffer_dirty;
bool pwm_buffer_dirty[IS31FL3733_CHUNK_COUNT];
uint8_t led_control_buffer[IS31FL3733_LED_CONTROL_REGISTER_COUNT];
bool led_control_buffer_dirty;
} PACKED is31fl3733_driver_t;
is31fl3733_driver_t driver_buffers[IS31FL3733_DRIVER_COUNT] = {{
.pwm_buffer = {0},
.pwm_buffer_dirty = false,
.pwm_buffer_dirty = {0},
.led_control_buffer = {0},
.led_control_buffer_dirty = false,
.led_control_bitfield = {0},
}};
void is31fl3733_write_register(uint8_t index, uint8_t reg, uint8_t data) {
@ -128,13 +132,21 @@ void is31fl3733_write_pwm_buffer(uint8_t index) {
// Transmit PWM registers in 12 transfers of 16 bytes.
// Iterate over the pwm_buffer contents at 16 byte intervals.
for (uint8_t i = 0; i < IS31FL3733_PWM_REGISTER_COUNT; i += 16) {
for (uint8_t i = 0; i < IS31FL3733_CHUNK_COUNT; i++) {
if (!driver_buffers[index].pwm_buffer_dirty[i]) {
continue;
}
driver_buffers[index].pwm_buffer_dirty[i] = false;
uint8_t offset = i * IS31FL3733_PWM_REGISTERS_PER_CHUNK;
#if IS31FL3733_I2C_PERSISTENCE > 0
for (uint8_t j = 0; j < IS31FL3733_I2C_PERSISTENCE; j++) {
if (i2c_write_register(i2c_addresses[index] << 1, i, driver_buffers[index].pwm_buffer + i, 16, IS31FL3733_I2C_TIMEOUT) == I2C_STATUS_SUCCESS) break;
if (i2c_write_register(i2c_addresses[index] << 1, offset, driver_buffers[index].pwm_buffer + offset, IS31FL3733_PWM_REGISTERS_PER_CHUNK, IS31FL3733_I2C_TIMEOUT) == I2C_STATUS_SUCCESS) break;
}
#else
i2c_write_register(i2c_addresses[index] << 1, i, driver_buffers[index].pwm_buffer + i, 16, IS31FL3733_I2C_TIMEOUT);
i2c_write_register(i2c_addresses[index] << 1, offset, driver_buffers[index].pwm_buffer + offset, IS31FL3733_PWM_REGISTERS_PER_CHUNK, IS31FL3733_I2C_TIMEOUT);
#endif
}
}
@ -211,7 +223,10 @@ void is31fl3733_set_color(int index, uint8_t red, uint8_t green, uint8_t blue) {
driver_buffers[led.driver].pwm_buffer[led.r] = red;
driver_buffers[led.driver].pwm_buffer[led.g] = green;
driver_buffers[led.driver].pwm_buffer[led.b] = blue;
driver_buffers[led.driver].pwm_buffer_dirty = true;
driver_buffers[led.driver].pwm_buffer_dirty[led.r / IS31FL3733_PWM_REGISTERS_PER_CHUNK] = true;
driver_buffers[led.driver].pwm_buffer_dirty[led.g / IS31FL3733_PWM_REGISTERS_PER_CHUNK] = true;
driver_buffers[led.driver].pwm_buffer_dirty[led.b / IS31FL3733_PWM_REGISTERS_PER_CHUNK] = true;
}
}
@ -252,12 +267,14 @@ void is31fl3733_set_led_control_register(uint8_t index, bool red, bool green, bo
}
void is31fl3733_update_pwm_buffers(uint8_t index) {
if (driver_buffers[index].pwm_buffer_dirty) {
is31fl3733_select_page(index, IS31FL3733_COMMAND_PWM);
is31fl3733_write_pwm_buffer(index);
driver_buffers[index].pwm_buffer_dirty = false;
for (uint8_t i = 0; i < IS31FL3733_CHUNK_COUNT; i++) {
if (driver_buffers[index].pwm_buffer_dirty[i]) {
// if any of these are true then write PWM buffer
// then exit the loop
is31fl3733_select_page(index, IS31FL3733_COMMAND_PWM);
is31fl3733_write_pwm_buffer(index);
return;
}
}
}