drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

Remove binary blobs from optical sensors. (#24428)

Browse source 
* remove pmw srom

* remove adns9800 srom

* Update drivers/sensors/pmw33xx_common.c
This commit is contained in:
Dasky 2024-10-06 08:41:55 +01:00 • committed by GitHub
parent 3d8cebb1a0
commit 43e82ed5c7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 64 additions and 792 deletions
Download patch file Download diff file Expand all files Collapse all files

32
drivers/sensors/pmw33xx_common.c
View file

@ -15,8 +15,7 @@
#include "spi_master.h"
#include "progmem.h"
extern const uint8_t pmw33xx_firmware_data[PMW33XX_FIRMWARE_LENGTH] PROGMEM;
extern const uint8_t pmw33xx_firmware_signature[3] PROGMEM;
extern const uint8_t pmw33xx_firmware_signature[2] PROGMEM;
static const pin_t cs_pins_left[] = PMW33XX_CS_PINS;
static const pin_t cs_pins_right[] = PMW33XX_CS_PINS_RIGHT;
@ -27,6 +26,14 @@ static bool in_burst_right[ARRAY_SIZE(cs_pins_right)] = {0};
bool __attribute__((cold)) pmw33xx_upload_firmware(uint8_t sensor);
bool __attribute__((cold)) pmw33xx_check_signature(uint8_t sensor);
uint16_t __attribute__((weak)) pmw33xx_srom_get_length(void) {
return 0;
}
uint8_t __attribute__((weak)) pmw33xx_srom_get_byte(uint16_t position) {
return 0;
}
void pmw33xx_set_cpi_all_sensors(uint16_t cpi) {
for (uint8_t sensor = 0; sensor < pmw33xx_number_of_sensors; sensor++) {
pmw33xx_set_cpi(sensor, cpi);
@ -89,10 +96,9 @@ uint8_t pmw33xx_read(uint8_t sensor, uint8_t reg_addr) {
}
bool pmw33xx_check_signature(uint8_t sensor) {
uint8_t signature_dump[3] = {
uint8_t signature_dump[2] = {
pmw33xx_read(sensor, REG_Product_ID),
pmw33xx_read(sensor, REG_Inverse_Product_ID),
pmw33xx_read(sensor, REG_SROM_ID),
};
return memcmp(pmw33xx_firmware_signature, signature_dump, sizeof(signature_dump)) == 0;
@ -115,10 +121,12 @@ bool pmw33xx_upload_firmware(uint8_t sensor) {
spi_write(REG_SROM_Load_Burst | 0x80);
wait_us(15);
for (size_t i = 0; i < PMW33XX_FIRMWARE_LENGTH; i++) {
spi_write(pgm_read_byte(pmw33xx_firmware_data + i));
for (size_t i = 0; i < pmw33xx_srom_get_length(); i++) {
spi_write(pmw33xx_srom_get_byte(i));
wait_us(15);
}
spi_stop();
wait_us(200);
pmw33xx_read(sensor, REG_SROM_ID);
@ -154,12 +162,14 @@ bool pmw33xx_init(uint8_t sensor) {
pmw33xx_read(sensor, REG_Delta_Y_L);
pmw33xx_read(sensor, REG_Delta_Y_H);
#ifdef PMW33XX_UPLOAD_SROM
if (!pmw33xx_upload_firmware(sensor)) {
pd_dprintf("PMW33XX (%d): firmware upload failed!\n", sensor);
return false;
if (pmw33xx_srom_get_length() != 0) {
if (!pmw33xx_upload_firmware(sensor)) {
pd_dprintf("PMW33XX (%d): firmware upload failed!\n", sensor);
return false;
}
} else {
pd_dprintf("PMW33XX (%d): firmware upload skipped.\n", sensor);
}
#endif
spi_stop();