drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

Report submodule status when not valid work-tree (#19474)

Browse source
This commit is contained in:
Joel Challis 2023-01-02 22:00:29 +00:00 • committed by GitHub
parent 0f5500182c
commit 3a5a4c708f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/python/qmk/cli/doctor/check.py
View file

@ -119,10 +119,8 @@ def check_submodules():
"""
for submodule in submodules.status().values():
if submodule['status'] is None:
cli.log.error('Submodule %s has not yet been cloned!', submodule['name'])
return CheckStatus.ERROR
elif not submodule['status']:
cli.log.warning('Submodule %s is not up to date!', submodule['name'])
return CheckStatus.WARNING
return CheckStatus.OK

2
lib/python/qmk/cli/doctor/main.py
View file

@ -142,7 +142,7 @@ def doctor(cli):
if sub_ok == CheckStatus.OK:
cli.log.info('Submodules are up to date.')
else:
if yesno('Would you like to clone the submodules?', default=True):
if git_check_repo() and yesno('Would you like to clone the submodules?', default=True):
submodules.update()
sub_ok = check_submodules()