drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

[Core] Add Repeat Key ("repeat last key") as a core feature. (#19700)

Browse source 
Co-authored-by: casuanoob <96005765+casuanoob@users.noreply.github.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
This commit is contained in:
Pascal Getreuer 2023-05-20 05:35:06 -07:00 • committed by GitHub
parent e1766df185
commit 3993b15f05
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
29 changed files with 2508 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/repeat_key/repeat_key_combo/config.h Normal file
View file

@ -0,0 +1,18 @@
// Copyright 2023 Google LLC
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 2 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
#pragma once
#include "test_common.h"

18
tests/repeat_key/repeat_key_combo/test.mk Normal file
View file

@ -0,0 +1,18 @@
# Copyright 2023 Google LLC
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
REPEAT_KEY_ENABLE = yes
COMBO_ENABLE = yes

67
tests/repeat_key/repeat_key_combo/test_repeat_key_combo.cpp Normal file
View file

@ -0,0 +1,67 @@
// Copyright 2023 Google LLC
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 2 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "keyboard_report_util.hpp"
#include "keycode.h"
#include "test_common.hpp"
#include "test_fixture.hpp"
#include "test_keymap_key.hpp"
using ::testing::AnyNumber;
using ::testing::InSequence;
namespace {
extern "C" {
// Define a combo: KC_X + KC_Y = KC_Q.
const uint16_t xy_combo[] PROGMEM = {KC_X, KC_Y, COMBO_END};
combo_t key_combos[] = {COMBO(xy_combo, KC_Q)};
uint16_t COMBO_LEN = sizeof(key_combos) / sizeof(*key_combos);
} // extern "C"
class RepeatKey : public TestFixture {};
// Tests repeating a combo, KC_X + KC_Y = KC_Q, by typing
// "X, Repeat, Repeat, {X Y}, Repeat, Repeat". This produces "xxxqqq".
TEST_F(RepeatKey, Combo) {
TestDriver driver;
KeymapKey key_x(0, 0, 0, KC_X);
KeymapKey key_y(0, 1, 0, KC_Y);
KeymapKey key_repeat(0, 2, 0, QK_REP);
set_keymap({key_x, key_y, key_repeat});
// Allow any number of empty reports.
EXPECT_EMPTY_REPORT(driver).Times(AnyNumber());
{
InSequence seq;
EXPECT_REPORT(driver, (KC_X));
EXPECT_REPORT(driver, (KC_X));
EXPECT_REPORT(driver, (KC_X));
EXPECT_REPORT(driver, (KC_Q));
EXPECT_REPORT(driver, (KC_Q));
EXPECT_REPORT(driver, (KC_Q));
}
tap_keys(key_x, key_repeat, key_repeat);
tap_combo({key_x, key_y});
EXPECT_KEYCODE_EQ(get_last_keycode(), KC_Q);
tap_keys(key_repeat, key_repeat);
testing::Mock::VerifyAndClearExpectations(&driver);
}
} // namespace