drashna/qmk_firmware
1
0
Fork 0
Code Activity Actions

Fix up tap_code functionality (#4609)

Browse source 
* Add delay in Tap Code to avoid issues

I think a few people have reporting issues with it working properly, and it may be a timing issue.  The 'register_code' uses this sort of delay in some of the functions, and
this is probably why.

Adding the 100ms delay should hopefully fix any issues with it.

* Make tap_code delay configurable

* Update documentation

* Bring tap_code16 inline with changes

* Fix type for tap_code16

Bad copy-paste job

* Just use the value check for the define

* Clarify timing in docs

Co-Authored-By: drashna <drashna@live.com>

* Wordsmithing

Co-Authored-By: drashna <drashna@live.com>
This commit is contained in:
Drashna Jael're 2018-12-14 09:01:58 -08:00 • committed by MechMerlin
parent 80dfd34fe4
commit 02d44beb44
6 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tmk_core/common/action.c
View file

@ -847,6 +847,18 @@ void unregister_code(uint8_t code)
#endif
}
/** \brief Utilities for actions. (FIXME: Needs better description)
*
* FIXME: Needs documentation.
*/
void tap_code(uint8_t code) {
register_code(code);
#if TAP_CODE_DELAY > 0
wait_ms(TAP_CODE_DELAY);
#endif
unregister_code(code);
}
/** \brief Utilities for actions. (FIXME: Needs better description)
*
* FIXME: Needs documentation.